Feature/CDP-160-CTAButton #42
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // 4οΈβ£ CTA | ||
| if (props.preset === "cta") { | ||
| const state = props.disabled ? "disabled" : "active"; | ||
| const classes = cn(getButtonClasses("cta", { state })); | ||
|
|
||
| const native = omitKeys(props, [ | ||
| "preset", | ||
| "disabled", | ||
| "fullWidth", | ||
| "className", | ||
| "asChild", | ||
| "children", | ||
| ] as const); | ||
| return { asChild, className, children, classes, native }; |
There was a problem hiding this comment.
In the new CTA branch disabled is used only to select the style and then stripped from the native props via omitKeys. Because the rendered <button> never receives its disabled attribute, a CTA marked as disabled is still focusable and its onClick executes (e.g. the marketing pageβs μ ν μλ£ button shows an alert even when disabled={!isReady}). This breaks accessibility expectations and allows actions to run while the UI appears disabled. The prop should be forwarded to the native button or the handler suppressed when disabled is true.
Useful? React with πΒ / π.
π Pull Request
π PR μ ν
π λ³κ²½ μ¬ν
CTA λ²νΌ κΈ°λ₯μ μΆκ° λ° λλ© νμ΄μ§μ νμ±ν & λΉνμ±ν μμΌλ¨μ
πΈ μ€ν¬λ¦°μ·
π§ κ΄λ ¨ μ΄μ
π οΈ μ΅μ’ λ°°ν¬ μ κ² λ¦¬μ€νΈ
β μ΅μ’ λ°°ν¬ μ κ² κ²°κ³Ό